search

GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.
https://geoscienceaustralia.github.io/PyRate/
Apache License 2.0
201 stars 71 forks source link

Changing the master and slave phrasing #280

Closed bopopescu closed 4 years ago

bopopescu commented 4 years ago

For diversity reasons, it would be nice to try to avoid 'master' and 'slave' terminology in this repository which can be associated to slavery. The master-slave terminology could be problematic for people in several countries which has the history of slavery like Romania, USA and many others. Thank you for considering the proposal. Let me know if any changes in the PR are needed, I would be happy to implement them.

codecov-commenter commented 4 years ago

Codecov Report

Merging #280 into master will not change coverage. The diff coverage is 93.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          26       26           
  Lines        3207     3207           
  Branches      495      495           
=======================================
  Hits         2988     2988           
  Misses        137      137           
  Partials       82       82
Impacted Files Coverage Δ
pyrate/core/gamma.py 97.93% <ø> (ø)
pyrate/core/roipac.py 91.52% <ø> (ø)
pyrate/process.py 91.78% <ø> (ø)
pyrate/core/algorithm.py 91.01% <66.66%> (ø)
pyrate/core/shared.py 95.24% <92.85%> (ø)
pyrate/core/aps.py 85.25% <100.00%> (ø)
pyrate/core/covariance.py 95.61% <100.00%> (ø)
pyrate/core/mst.py 96.29% <100.00%> (ø)
pyrate/core/orbital.py 95.70% <100.00%> (ø)
pyrate/core/timeseries.py 90.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f914bf5...d7d3688. Read the comment docs.

mcgarth commented 4 years ago

Hi @bopopescu , we totally agree! This one has been on our radar for a few weeks. See https://github.com/GeoscienceAustralia/PyRate/issues/278

I have been progressing the removal of "master" and "slave" from our codebase since then, and lodged a PR today, see https://github.com/GeoscienceAustralia/PyRate/pull/281

Your PR does the same as mine so I am closing it. However, I hope your concerns are addressed by my PR (comment there if not please). The changes will make it in to our mainline branch within a month.