search

GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.
https://geoscienceaustralia.github.io/PyRate/
Apache License 2.0
201 stars 71 forks source link

Mg/linrate #289

Closed uniomni closed 4 years ago

uniomni commented 4 years ago

Updated README.rst with instructions how to run the tests

uniomni commented 4 years ago

Made input checks in more explicit. I think it reads better that way.

codecov-commenter commented 4 years ago

Codecov Report

Merging #289 into mg/linrate will decrease coverage by 0.78%. The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           mg/linrate     #289      +/-   ##
==============================================
- Coverage       85.58%   84.80%   -0.79%     
==============================================
  Files              26       26              
  Lines            3628     3389     -239     
  Branches          620      525      -95     
==============================================
- Hits             3105     2874     -231     
+ Misses            417      416       -1     
+ Partials          106       99       -7
Impacted Files Coverage Δ
pyrate/core/timeseries.py 90.73% <100.00%> (ø)
pyrate/core/orbital.py 92.59% <0.00%> (-1.60%) :arrow_down:
pyrate/core/prepifg_helper.py 95.17% <0.00%> (-1.16%) :arrow_down:
pyrate/configuration.py 96.09% <0.00%> (-0.97%) :arrow_down:
pyrate/core/config.py 93.47% <0.00%> (+1.60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f99a038...e217a6f. Read the comment docs.

mcgarth commented 4 years ago

Thanks for your contribution. I have cherry-picked the changes to README.rst and commited them to PyRate's develop branch: https://github.com/GeoscienceAustralia/PyRate/commit/fa33f542dc63de3967c529a15c83a1e946c24418

I have not included the explicit check for vector length included in this PR. But in the version of the function linear_rate_pixel merged in to develop, an IndexError is raised when we do the operation t = t[mask] and unequal vectors y and t were passed to the function. I catch that and raise a "TimeSeriesError" exception with a message saying that "y and t are not equal length". I think this should make it clear to the user that y and t should be equal. See https://github.com/GeoscienceAustralia/PyRate/commit/f99a038bbd216a8cbbaf898d5bc2612ed9009673