GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.
https://geoscienceaustralia.github.io/PyRate/
Apache License 2.0
200 stars 70 forks source link

Co/plot scripts #312

Closed chandra2ga closed 3 years ago

chandra2ga commented 3 years ago

This PR is about including additional python plot scripts for visualization. This includes three plot scripts: 1) plot_time_series_errbar_vel_err_rsqr.py :

Other details are highlighted in PIS-154: https://gajira.atlassian.net/secure/RapidBoard.jspa?rapidView=480&projectKey=PIS&modal=detail&selectedIssue=PIS-154

chandra2ga commented 3 years ago

Thanks @neginmoghaddam and @adeane-ga for all the suggestion for the plot script. Here I updated all the 3 plot scripts considering all of your feedbacks. Major changes are as follows:

  1. plot_time_series_errbar_vel_err_rsqr.py: Included adaptive scale bar limit for velocity and displacement time-series, changed model fitting color, and included tscuml legend to the time-series
  2. LOS_tscuml_animation.py : Included adaptive scale bar limit, changed date location to top center, reduced the frame speed
  3. plot_vel_profile.py : Included adaptive scale bar limit, replaced print command asking for user input with an automatic one.

Let me know if any further changes required. Thanks

NMoghaddam commented 3 years ago

Thank you @chandra2ga for the recent changes. The plotting scripts improved significantly, and I express my approval for final review. A few comments as below might be worthwhile to be considered:

adeane-ga commented 3 years ago

@chandra2ga: I have also just done a 2nd review of the with the updates to co/plot_scripts by using the plot_time_series_errbar_vel_err_rsqr.py, LOS_tscuml_animation.py, and plot_vel_profile.py on the CROP-B of Mexico data.

Thanks :)

chandra2ga commented 3 years ago

Here I updated all the three plot scripts with zero as white color on colorbar for both velocity and displacement maps.

1) Regards to Negin comment on typo issue on plot script plot_time_series_errbar_vel_err-rsqr.py: The command line tslider.ax.xaxis.set_major_formatter(mdates.ConciseDateFormatter(loc_tslider)) responsible for making that changes as default. So unable to remove that print from the plot maps. 2) Regarding the plot disappear on plot_vel_profile.py as Negin mentioned: I don't have such issue while plotting. Negin might need to check some module version settings that may cause such issue.

Let me know if any other changes required for plotting. Thanks for all the suggestions and review.