Closed chandra2ga closed 3 years ago
Thanks @neginmoghaddam and @adeane-ga for all the suggestion for the plot script. Here I updated all the 3 plot scripts considering all of your feedbacks. Major changes are as follows:
Let me know if any further changes required. Thanks
Thank you @chandra2ga for the recent changes. The plotting scripts improved significantly, and I express my approval for final review. A few comments as below might be worthwhile to be considered:
plot_time_series_errbar_vel_err-rsqr.py
script:
Everything looks perfect now just a typo issue in pixel TS graph. In the lower-right corner, we have an extra 2019
string. That would be great to be removed. LOS_tscuml_animation.py
script:
The changes implemented and everything looks good. Just a note on the scalebar- for Mexico dataset, for instance, the colour saturation that was reported previously was uplifted but I have concerns around the scale bar showing values between -50 and 250 with not having 0 in the middle of the bar (a.k.a stable~zero displacement)plot_vel_profile.py
script:
It looks really good now; however, two items I would like to raise that might be an issue with Matplotlib: (a) Some times when the script is being called, there is a point already in the map (starting point), and when the user does the click, the profile will be shown (b) I tested this script a few times, and I occasionally noticed that after a 5sec pause in interaction with the map, the plot would disappear with no warning.
@chandra2ga: I have also just done a 2nd review of the with the updates to co/plot_scripts by using the plot_time_series_errbar_vel_err_rsqr.py
, LOS_tscuml_animation.py
, and plot_vel_profile.py
on the CROP-B of Mexico data.
Thanks :)
Here I updated all the three plot scripts with zero as white color on colorbar for both velocity and displacement maps.
1) Regards to Negin comment on typo issue on plot script plot_time_series_errbar_vel_err-rsqr.py: The command line tslider.ax.xaxis.set_major_formatter(mdates.ConciseDateFormatter(loc_tslider)) responsible for making that changes as default. So unable to remove that print from the plot maps. 2) Regarding the plot disappear on plot_vel_profile.py as Negin mentioned: I don't have such issue while plotting. Negin might need to check some module version settings that may cause such issue.
Let me know if any other changes required for plotting. Thanks for all the suggestions and review.
This PR is about including additional python plot scripts for visualization. This includes three plot scripts: 1) plot_time_series_errbar_vel_err_rsqr.py :
Other details are highlighted in PIS-154: https://gajira.atlassian.net/secure/RapidBoard.jspa?rapidView=480&projectKey=PIS&modal=detail&selectedIssue=PIS-154