search

GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.
https://geoscienceaustralia.github.io/PyRate/
Apache License 2.0
200 stars 70 forks source link

Deprecate OBS_DIR, SLC_DIR and COH_FILE_DIR parameters #330

Closed basaks closed 3 years ago

basaks commented 3 years ago

OBS_DIR, SLC_DIR and COH_FILE_DIR are no longer used as config parameters. These params are removed from code and config files.

WORKING_DIR replaces OBS_DIR in the test suite

basaks commented 3 years ago

This successfully removes the stated parameters from the code, with the exception of OBS_DIR which is renamed to WORKING_DIR. All looks good to me, but if WORKING_DIR is still a valid part of the configuration, should it be exposed/added to the example .conf files?

Hey, working dir is not a valid part of the conf file. You may choose to

This successfully removes the stated parameters from the code, with the exception of OBS_DIR which is renamed to WORKING_DIR. All looks good to me, but if WORKING_DIR is still a valid part of the configuration, should it be exposed/added to the example .conf files?

@richardt94 the string working_dir is only used in the tests, and as such I have moved it into the tests.common file. We don't need to expose it to the user. May be this is more suitable as not part of the core pyrate files.

richardt94 commented 3 years ago

Definitely happier with having the WORKING_DIR parameter in tests rather than the core files - I approve the changes now