Rename phase closure params

GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.

https://geoscienceaustralia.github.io/PyRate/

Apache License 2.0

200 stars 70 forks source link

Rename phase closure params #340

Closed mcgarth closed 3 years ago

mcgarth commented 3 years ago

In this PR, phase closure has been modified as follows:

rename three phase closure params, as agreed with the team
refactored code to use the new param names
Added a worked example of phase closure usage to the Readme: https://github.com/GeoscienceAustralia/PyRate/blob/mg/phs_cls_param_rename/pyrate/core/phase_closure/readme.md
Changed the code behaviour when zero loops are returned from an iteration - i.e. don't fall over completely!

mcgarth commented 3 years ago

Did you want to add the pngs? If not, they should be purged properly.

Yes I added them so that they can be shown in the markdown document

Update 16/7/2021: I have replaced the png images with down-sized versions to save a bit of space in the repo

richardt94 commented 3 years ago

We should consider renaming avg_ifg_err_thr to reflect the changes from #343 that have now been rebased into this PR. I will look at this when I review after 30 June.