GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.
https://geoscienceaustralia.github.io/PyRate/
Apache License 2.0
203 stars 71 forks source link

Bug: Y-Intercept output incorrect if signal polarity option (-1) is used #353

Closed adeane-ga closed 2 years ago

adeane-ga commented 3 years ago

Description

Expected Behaviour

Testing

SciPy Rate: -223.43657517299133 SciPy Y-Intercept: -28.24114861088961

PyRate Rate: -223.4365692138672 PyRate Y-Intercept: 28.24115562438965

Action

https://github.com/GeoscienceAustralia/PyRate/blob/dde59c67bc8eb637012dfa5a80e3a535896c8ec2/pyrate/merge.py#L290-L327

Visuals

What we should see: image

What PyRate produces: image

adeane-ga commented 2 years ago

Closing this issue because it was fixed with this merge: https://github.com/GeoscienceAustralia/PyRate/pull/368