GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.
https://geoscienceaustralia.github.io/PyRate/
Apache License 2.0
199 stars 69 forks source link

Added list creator #376

Closed s-m-t-c closed 2 years ago

s-m-t-c commented 2 years ago

This is a small helper script that makes input lists for PyRate based on the output of Gamma. It also prints the number of files in each category (interferograms, coherence files etc).

If you have a similar script that offers improvements feel free to modify this PR.

adeane-ga commented 2 years ago
mcgarth commented 2 years ago

Hi @s-m-t-c, was there a reason you needed to pin a version to GDAL? I remember that we left this blank because the version gets found and updated based on system GDAL found during running of python setup.py install. @basaks might remember more...

s-m-t-c commented 2 years ago

@mcgarth I was actually just trying to get the CI checks to pass and thought it might be because the GDAL version had changed. This doesn't seem to solve the problem though so I will revert it. Any ideas on why they're failing?

mcgarth commented 2 years ago

I think the CI fails are not related to the script addition you have made here. The script is not covered by the test suite (nothing in utils dir is covered, and doesn't need to be IMO). I think you can safely revert your branch here back to 3a31a6b and merge to develop despite the CI fail. After the merge, if develop is failing then there will need to be a separate investigation as to why (seems to be related to gdal not getting imported in to test environment)

adu461386118 commented 2 years ago