GeoscienceAustralia / agdc

Repository for Australian Geoscience Data Cube (AGDC) code
BSD 3-Clause "New" or "Revised" License
29 stars 24 forks source link

Make 'path' config optional for Modis ingestion. #64

Closed jeremyh closed 9 years ago

jeremyh commented 9 years ago

The Modis ingester fails when no path/row constraints are specified (it tries to convert None to int).

Previous tests appear to have worked around this by setting large min/max values (-99999 and 99999), but a better solution is to make the values optional.

wenjunwu commented 9 years ago

Thanks for fixing this one.

From: Jeremy Hooke [mailto:notifications@github.com] Sent: Friday, 5 June 2015 2:36 PM To: GeoscienceAustralia/agdc Subject: [agdc] Make 'path' config optional for Modis ingestion. (#64)

The Modis ingester fails when no path/row constraints are specified (it tries to convert None to int).

Previous tests appear to have worked around this by setting large min/max values (-99999 and 99999), but a better solution is to make the values optional.


You can view, comment on, or merge this pull request online at:

https://github.com/GeoscienceAustralia/agdc/pull/64

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/GeoscienceAustralia/agdc/pull/64.

Geoscience Australia Disclaimer: This e-mail (and files transmitted with it) is intended only for the person or entity to which it is addressed. If you are not the intended recipient, then you have received this e-mail by mistake and any use, dissemination, forwarding, printing or copying of this e-mail and its file attachments is prohibited. The security of emails transmitted cannot be guaranteed; by forwarding or replying to this email, you acknowledge and accept these risks.