search

GeoscienceAustralia / agdc

Repository for Australian Geoscience Data Cube (AGDC) code
BSD 3-Clause "New" or "Revised" License
29 stars 24 forks source link

Fix microsecond date/time parsing #65

Closed smr547 closed 9 years ago

smr547 commented 9 years ago

When using Tile.from_csv_record(record) the parse_datetime() does not capture the microsecond element of the timestamp. This cause problems for downstream processing where applications (e.g. WOfS) rely on the full timestamp as an identifier. The alternative of extracting this info from NBAR filenames is not appealing.

The AGDC uses a variety of date/time formats roughly aligned to (but not all compatible with) ISO8601. The proposed function uses a regex to match all formats so far encountered by the author.

wenjunwu commented 9 years ago

This request will create a complex merge history (below). Can it be simplified? E.g. close this request, check out the current “develop” branch, make the change, then make a pull request?

From: Steven Ring [mailto:notifications@github.com] Sent: Sunday, 7 June 2015 11:21 PM To: GeoscienceAustralia/agdc Subject: [agdc] Fix microsecond date/time parsing (#65)

When using Tile.from_csv_record(record) the parse_datetime() does not capture the microsecond element of the timestamp. This cause problems for downstream processing where applications (e.g. WOfS) rely on the full timestamp as an identifier. The alternative of extracting this info from NBAR filenames is not appealing.

The AGDC uses a variety of date/time formats roughly aligned to (but not all compatible with) ISO8601. The proposed function uses a regex to match all formats so far encountered by the author.

You can view, comment on, or merge this pull request online at:

https://github.com/GeoscienceAustralia/agdc/pull/65

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/GeoscienceAustralia/agdc/pull/65.

Geoscience Australia Disclaimer: This e-mail (and files transmitted with it) is intended only for the person or entity to which it is addressed. If you are not the intended recipient, then you have received this e-mail by mistake and any use, dissemination, forwarding, printing or copying of this e-mail and its file attachments is prohibited. The security of emails transmitted cannot be guaranteed; by forwarding or replying to this email, you acknowledge and accept these risks.

smr547 commented 9 years ago

Hi Wenjun,

I'm happy to do that.

The complexity arose because my fork was out of date and I had to merge a lot of update. I'll simplify as suggested and get back to you.

cheers Steven

On Tue, Jun 9, 2015 at 10:57 AM, Wenjun Wu notifications@github.com wrote:

This request will create a complex merge history (below). Can it be simplified? E.g. close this request, check out the current “develop” branch, make the change, then make a pull request?

  • Merge branch 'develop' of github.com:smr547/agdc into develop
  • Merge branch 'develop' of github.com:GeoscienceAustralia/agdc into develop
  • Merge branch 'master' of github.com:GeoscienceAustralia/agdc into develop

From: Steven Ring [mailto:notifications@github.com] Sent: Sunday, 7 June 2015 11:21 PM To: GeoscienceAustralia/agdc Subject: [agdc] Fix microsecond date/time parsing (#65)

When using Tile.from_csv_record(record) the parse_datetime() does not capture the microsecond element of the timestamp. This cause problems for downstream processing where applications (e.g. WOfS) rely on the full timestamp as an identifier. The alternative of extracting this info from NBAR filenames is not appealing.

The AGDC uses a variety of date/time formats roughly aligned to (but not all compatible with) ISO8601. The proposed function uses a regex to match all formats so far encountered by the author.

You can view, comment on, or merge this pull request online at:

https://github.com/GeoscienceAustralia/agdc/pull/65

Commit Summary

  • Update README
  • Merge branch 'develop' of github.com:smr547/agdc into develop
  • Merge branch 'develop' of github.com:GeoscienceAustralia/agdc into develop
  • Merge branch 'master' of github.com:GeoscienceAustralia/agdc into develop
  • Fix microsecond time/date parsing in model

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/GeoscienceAustralia/agdc/pull/65>.

Geoscience Australia Disclaimer: This e-mail (and files transmitted with it) is intended only for the person or entity to which it is addressed. If you are not the intended recipient, then you have received this e-mail by mistake and any use, dissemination, forwarding, printing or copying of this e-mail and its file attachments is prohibited. The security of emails transmitted cannot be guaranteed; by forwarding or replying to this email, you acknowledge and accept these risks.

— Reply to this email directly or view it on GitHub https://github.com/GeoscienceAustralia/agdc/pull/65#issuecomment-110185312 .

Steven Ring Software Engineer BSc MIT (ANU) m: 0417 495 268 f: +61 2 6100 9273 s: stevering

smr547 commented 9 years ago

Closing to tidy-up history