benjimin
commented
2 days ago Closely related, there has been a request to move the splash announcement into a separate (html) file. This multiline blob is very markup heavy, and having it embedded in a yaml field is unwieldy from the perspective of content editors. (It also potentially gets mangled by envsubst, etc.)
Ideally, there may be some way to relocate this together with the other html branding templates (currently in a different repo).
benji-glitsos-ga
Closely related to #10, we should relocate residual environment-specific configuration from the templating injected by the kustomisation that is buried in the datakube-apps (generic overarching fluxCD) repo, and consolidate it with the overlays in the dea-jupyterhub (app-specific) repo.
From a UX/comms perspective, the login splash screen announcement is especially important (and potentially updated frequently). It is currently specified by one such kustomize/envsubst template variable, but need to ensure it is configured somewhere easy to locate and update. Could decide to keep it in the parent repo (if that repo's release workflow is preferred), in which case we still need central docs (readme) to help point at it.