Closed robbibt closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
geoscience-aman commented on 2023-07-04T05:21:21Z ----------------------------------------------------------------
Markdown for a warning box maybe?
<div class="alert alert-block alert-warning"> <b>Warning:</b> Keep these extents as small as possible for reasonable loading times! </div>
Great idea, will try it out
_robbibt commented on 2023-07-04T05:41:20Z_ ----------------------------------------------------------------Will do a teal "info" box instead, feels friendlier!
View / edit / reply to this conversation on ReviewNB
geoscience-aman commented on 2023-07-04T05:21:22Z ----------------------------------------------------------------
Is it worth adding a note to say that not all datasets in the catalogue are currently available in the Planetary Computer API?
E.g. https://planetarycomputer.microsoft.com/dataset/storage/ghe
View / edit / reply to this conversation on ReviewNB
geoscience-aman commented on 2023-07-04T05:21:23Z ----------------------------------------------------------------
Line #9. axes[1].set_title("DEA Land Cover\nLevel 3 class 124 ('Natural Aquatic Vegetation')");
Maybe the following code under this line to add some space between the legend label of the left plot and the ylabel of the right plot?
plt.subplots_adjust(wspace=0.35)
Neat, will do
_robbibt commented on 2023-07-04T05:34:30Z_ ----------------------------------------------------------------Actually, I might switch to a more intuitive cmap and strip out the legends completely, they don't really do much here
View / edit / reply to this conversation on ReviewNB
geoscience-aman commented on 2023-07-04T05:21:24Z ----------------------------------------------------------------
Line #4. # Apply USGS scaling factors to obtain temperature in Kelvins
Is it worth saying 'Collection 2 USGS scaling ...' in case someone accidentally applies the same scaling to Landsat Collection 1?
Yes, absolulety - will update
View / edit / reply to this conversation on ReviewNB
geoscience-aman commented on 2023-07-04T05:21:25Z ----------------------------------------------------------------
Line #9. axes[1].set_title("USGS Landsat surface temperature");
Same as before under this line too to prevent overlapping text maybe?
plt.subplots_adjust(wspace=0.35)
Actually, I might switch to a more intuitive cmap and strip out the legends completely, they don't really do much here
View entire conversation on ReviewNB
Proposed changes
This PR adds a new notebook for loading data from Microsoft Planetary Computer and combining it with DEA data, including:
odc.stac
Closes issues (optional)
Checklist (replace
[ ]
with[x]
to check off)Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).NCI
andDEA Sandbox
(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment only
line below the notebook title to reflect the environments the notebook is compatible with