GeoscienceAustralia / dea-notebooks

Repository for Digital Earth Australia Jupyter Notebooks: tools and workflows for geospatial analysis with Open Data Cube and Xarray
https://docs.dea.ga.gov.au/notebooks/
Apache License 2.0
439 stars 127 forks source link

Fixed several links after running link checker tools on the site #1161

Closed benji-glitsos-ga closed 8 months ago

benji-glitsos-ga commented 8 months ago

Proposed changes

Fixed several links after running link checker tools on the site

Closes issues (optional)

None

Checklist (replace [ ] with [x] to check off)

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

robbibt commented 8 months ago

Hey @benjamin-glitsos, the reason for those relative links to scripts and notebooks is so that users can click through them on the DEA Sandbox and have the coresponding script open up to access the code. It's pretty important, particularly for notebooks that form a set that are run in order (e.g. "Click to launch Notebook 2 of 5" etc).

Is there any way we can continue to use relative links in the Notebooks and still have them load correctly in Knowledge Hub? That used to work in the original DEA Docs.

benji-glitsos-ga commented 8 months ago

Hi Robbi, I'll try to find a solution. The problem is that the relative links weren't working when rendered on the Knowledge Hub site.

robbibt commented 8 months ago

Thanks @benjamin-glitsos! I've just realised that most of the relative links to notebooks and scripts were actually removed in the previous PR, not this one... we'll probably need to revert those changes to restore them so they work correctly for our Sandbox users, so some way of dealing with relative links in KH would be ideal.

I wonder if this could be dealt with via yet more redirects? e.g. updating the auto-resolved URL with one that points to the correct KH location...