GeoscienceAustralia / dea-notebooks

Repository for Digital Earth Australia Jupyter Notebooks: tools and workflows for geospatial analysis with Open Data Cube and Xarray
https://docs.dea.ga.gov.au/notebooks/
Apache License 2.0
433 stars 127 forks source link

Updates to DEA Waterbodies notebooks and tools for v3.0 #1199

Closed BexDunn closed 4 months ago

BexDunn commented 4 months ago

Proposed changes

Updates to DEA Waterbodies notebooks and tools to support DEA Waterbodies v3.0

Checklist

(Replace [ ] with [x] to check off)

sandbox_spellchecker

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

whatnick commented 4 months ago

Please see the concurrent v2/v3 support I have proposed here : https://github.com/whatnick/dea-notebooks/blob/feat/waterbody-version/Tools/dea_tools/waterbodies.py

benji-glitsos-ga commented 4 months ago

It's looking really good. I'm just wondering, should the Disclaimer be under a heading, similar to the following 'Applications' section? This is because the disclaimer is two paragraphs long.

robbibt commented 4 months ago

This is looking awesome @BexDunn! Re the disclaimer, we have a precedent for using alert boxes for this kind of thing, e.g.: image

I wouldn't recommend a bright red one like this, but we could probably pop it in a blue or yellow alert if we wanted to make it a bit more obvious. 🙂 (personally I'd like to expand our use of alert boxes like these throughout the repo - I think they catch the eye nicely and follow best practice from recent papers, e.g. section 3.2 here)

benji-glitsos-ga commented 4 months ago

I didn't think of this sooner @BexDunn - in the notebook file, could we change all the Knowledge Hub links to point to the new URL? There are four links that point to "docs.dea.ga.gov.au" but they can be changed to "knowledge.dea.ga.gov.au".

E.g.

[DEA Waterbodies](https://docs.dea.ga.gov.au/data/product/dea-waterbodies-landsat)

... change to ...

[DEA Waterbodies](https://knowledge.dea.ga.gov.au/data/product/dea-waterbodies-landsat)