Closed BexDunn closed 4 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Please see the concurrent v2/v3 support I have proposed here : https://github.com/whatnick/dea-notebooks/blob/feat/waterbody-version/Tools/dea_tools/waterbodies.py
It's looking really good. I'm just wondering, should the Disclaimer be under a heading, similar to the following 'Applications' section? This is because the disclaimer is two paragraphs long.
This is looking awesome @BexDunn! Re the disclaimer, we have a precedent for using alert boxes for this kind of thing, e.g.:
I wouldn't recommend a bright red one like this, but we could probably pop it in a blue or yellow alert if we wanted to make it a bit more obvious. 🙂 (personally I'd like to expand our use of alert boxes like these throughout the repo - I think they catch the eye nicely and follow best practice from recent papers, e.g. section 3.2 here)
I didn't think of this sooner @BexDunn - in the notebook file, could we change all the Knowledge Hub links to point to the new URL? There are four links that point to "docs.dea.ga.gov.au" but they can be changed to "knowledge.dea.ga.gov.au".
E.g.
[DEA Waterbodies](https://docs.dea.ga.gov.au/data/product/dea-waterbodies-landsat)
... change to ...
[DEA Waterbodies](https://knowledge.dea.ga.gov.au/data/product/dea-waterbodies-landsat)
Proposed changes
Updates to DEA Waterbodies notebooks and tools to support DEA Waterbodies v3.0
Checklist
(Replace
[ ]
with[x]
to check off)Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).NCI
andDEA Sandbox
- I haven't tested it on the NCI, but I haven't made any major changes and haven't logged into NCI for a very long time...Notebook currently compatible with the NCI|DEA Sandbox environment only
line below the notebook title to reflect the environments the notebook is compatible with