GeoscienceAustralia / dea-notebooks

Repository for Digital Earth Australia Jupyter Notebooks: tools and workflows for geospatial analysis with Open Data Cube and Xarray
https://docs.dea.ga.gov.au/notebooks/
Apache License 2.0
442 stars 128 forks source link

Update WIT to add note about loading polygons without elevation values #1250

Closed LaurenSchenk1 closed 1 month ago

LaurenSchenk1 commented 1 month ago

Proposed changes

Include a note in WIT notebook when loading polygons to remove any Z/elevation values

Checklist

(Replace [ ] with [x] to check off)

sandbox_spellchecker

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

robbibt commented 1 month ago

Hey @LaurenSchenk1, no issues with this and happy to approve, but out of curiousity, do we know what's going wrong here? Seems like a weird one (would have expected WIT to be just using the geometry of the polygons, not any of their fields). Perhaps something that we might want to think about fixing in the WIT code itself (or at least raising some kind of warning/error so it doesn't fail silently)