Closed abradley60 closed 1 week ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@geoscience-aman this has both of our changes. Can you confirm it looks good? Also, will this be cloned down to users sandbox's on login during the session? Or does another branch get clones?
@geoscience-aman this has both of our changes. Can you confirm it looks good? Also, will this be cloned down to users sandbox's on login during the session? Or does another branch get clones?
Has my changes and looks good to me! I have made a commit with minor formatting improvements.
I think it's the stable
branch that gets cloned. Can you please confirm @robbibt?
Hey @geoscience-aman @abradley60, the Sandbox sync comes from stable
- once this PR is merged into develop
, we can aim to merge develop
into stable
ASAP so it will sync automatically!
Hey @abradley60, left some tiny comments, if you can fix these up I can approve and we can merge this in!
Proposed changes
Include a brief description of the changes being proposed, and why they are necessary.
Closes issues (optional)
Checklist
(Replace
[ ]
with[x]
to check off)Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).NCI
andDEA Sandbox
(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment only
line below the notebook title to reflect the environments the notebook is compatible with