`pytmd_model.format` tests in coastal module need updating for latest pyTMD

GeoscienceAustralia / dea-notebooks

Repository for Digital Earth Australia Jupyter Notebooks: tools and workflows for geospatial analysis with Open Data Cube and Xarray

https://docs.dea.ga.gov.au/notebooks/

Apache License 2.0

448 stars 128 forks source link

`pytmd_model.format` tests in coastal module need updating for latest pyTMD #1265

Open jessjaco opened 2 months ago

jessjaco commented 2 months ago

The various tests for pytmd_model.format in coastal.py, e.g. https://github.com/GeoscienceAustralia/dea-notebooks/blob/0c4268d2db43ef7888e1d79f482ad0ee0fb89787/Tools/dea_tools/coastal.py#L292

need to be updated for the new values in pyTMD.model of ATLAS-compact, FES-ascii, FES-netcdf, etc. listed here: https://github.com/tsutterley/pyTMD/blob/0f6a07c8723a67b02eade42feb211df8a78b8321/pyTMD/io/model.py#L148-L158

I believe pyTMD version 2.1.4 is the last working version.

robbibt commented 2 months ago

Thanks @jessjaco - pinning to pyTMD 2.1.4 is the best temporary solution - feel free to raise a PR here pinning that version in our setup.py!

https://github.com/GeoscienceAustralia/dea-notebooks/blob/develop/Tools%2Fsetup.py#L59

We should chat about this in more detail at some point - we're currently in the process of spinning off all our tide modelling to a smaller, easier to install Python package (eo-tides). Should make managing changes to the tide modelling code much easier in the the future!

jessjaco commented 2 months ago

Ok, I noticed some of the recent updates to pyTMD and I'm just trying to stay on top of them. (The addition of the crop functionality helped speed things up a lot.) Looking forward to hearing about the new package!