search

GeoscienceAustralia / dea-orchestration

4 stars 1 forks source link

Deploy automatically, fix security bug, simplify raijin scripts #143

Closed omad closed 4 years ago

omad commented 4 years ago

It was previously been possible to execute any file on raijin, include scripts writable by arbitrary users, by passing ../../ etc as part of the command name. This was still protected by using safe SSH keys, but circumvented the intended white list of available commands.

Most of the scripts we have are a single script, and I find it awkward that they must be contained within a subdirectory and all the the same name. This PR allows following the current convention, or having a single file be the runnable script.

codecov[bot] commented 4 years ago

Codecov Report

Merging #143 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   62.75%   62.75%           
=======================================
  Files          20       20           
  Lines        1278     1278           
=======================================
  Hits          802      802           
  Misses        476      476

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e968b2c...6ce9cd7. Read the comment docs.