GeoscienceAustralia / dea-orchestration

4 stars 1 forks source link

Add ruptures conda package to dea env #152

Closed santoshamohan closed 4 years ago

santoshamohan commented 4 years ago

Background

Robbi was working on a break-point / change detection from time series data, and have found ruptures package to be extremely useful for his work. Running it locally as a custom Python install works for him. Issue arises when we qsub jobs on gadi compute nodes.

Proposed solution

codecov[bot] commented 4 years ago

Codecov Report

Merging #152 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   55.84%   55.84%           
=======================================
  Files          28       28           
  Lines        1832     1832           
=======================================
  Hits         1023     1023           
  Misses        809      809

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 587020e...809a781. Read the comment docs.

omad commented 4 years ago

Can you please update the PR description with some more info, eg. who has requested the package and what it is for. In a couple of years time, or when it starts to conflict with other packages, it's nice to be able to go back and find out what it was for and why.

Cheers D

omad commented 4 years ago

Also, we should try to limit the number of packages we install for everyone, otherwise maintenance is going to get out of hand. If users are happy running pip install --user, and it works for them, we should stick with that. Especially for packages that are from alternative conda channels.