GeoscienceAustralia / dea-sandbox

Digital Earth Australia Sandbox config and planning
Apache License 2.0
13 stars 6 forks source link

Pin scipy to >=1.10.1 #257

Closed robbibt closed 1 year ago

robbibt commented 1 year ago

A bug in Scipy 1.10.0 has broken some of our DEA Notebooks and coastal functions, reported here: https://github.com/GeoscienceAustralia/dea-notebooks/issues/1063

This PR pins to scipy versions >= 1.10.1 which fix this bug. More details: https://github.com/scipy/scipy/issues/17718

robbibt commented 1 year ago

Hey @emmaai, the integration tests failed on this PR due to the missing tide modelling files, e.g.

emmaai commented 1 year ago

It's the time that I need to sync your change in dea-notebooks wrt tidal model.

robbibt commented 1 year ago

Hey @emmaai, I re-ran the tests here after merging the DEA Notebooks fix, and it looks like the integration tests now pass!