search

GeoscienceAustralia / digitalearthau

Code and tools for Digital Earth Australia (a deployment of Open Data Cube)
https://geoscienceaustralia.github.io/digitalearthau/
31 stars 21 forks source link

S2 Nbart Product Definition #282

Closed kieranricardo closed 3 years ago

kieranricardo commented 3 years ago

This PR adds a product definition for the S2 Nbart data that will soon be added to AWS. The metadata type is eo3 and the product names are s2a_ard_granule and s2b_ard_granule. I tested this locally and successfully indexed some datasets stored here

This product definition was adapted from https://github.com/GeoscienceAustralia/dea-config/blob/master/products/ga_s2_ard_nbar/ga_s2_ard_nbar_granule.yaml and the exact changes can be seen by comparing the first and last commits. tldr I changed nbar to nbart and changed the metadata field to just contain the product name, but I'm not sure whether the deleted metadata was important!

codecov[bot] commented 3 years ago

Codecov Report

Merging #282 (3f61603) into develop (e5b7e25) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #282   +/-   ##
========================================
  Coverage    67.10%   67.10%           
========================================
  Files           42       42           
  Lines         3219     3219           
========================================
  Hits          2160     2160           
  Misses        1059     1059

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5b7e25...3f61603. Read the comment docs.

kieranricardo commented 3 years ago

@alexgleith thanks for the speedy review! I moved it into the right folder, and added the same license as the other docs