GeoscienceAustralia / digitalearthau

Code and tools for Digital Earth Australia (a deployment of Open Data Cube)
https://geoscienceaustralia.github.io/digitalearthau/
31 stars 21 forks source link

Add USGS C2 L1 product definition #285

Closed jeremyh closed 3 years ago

jeremyh commented 3 years ago

It passes eo3-validate against the test dataset that @dunkgray added to eodataset3, though I haven't tested data loading.

jeremyh commented 3 years ago

(And I assume the data is still CC-BY-4.0 licensed, right?)

dunkgray commented 3 years ago

RE (And I assume the data is still CC-BY-4.0 licensed, right?) Good assumption. I googled around and I could not find any licensing info.

dunkgray commented 3 years ago

Hi Jeremy, Could you add the product name to this test - integration_tests/test_config.py, so they pass and this can be merged. Thanks!

codecov[bot] commented 3 years ago

Codecov Report

Merging #285 (2b1d5f6) into develop (9b7fa41) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #285   +/-   ##
========================================
  Coverage    67.10%   67.10%           
========================================
  Files           42       42           
  Lines         3219     3219           
========================================
  Hits          2160     2160           
  Misses        1059     1059           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b7fa41...2b1d5f6. Read the comment docs.

dunkgray commented 3 years ago

Thanks! Are you ok with me merging this now?