search

GeoscienceAustralia / digitalearthau

Code and tools for Digital Earth Australia (a deployment of Open Data Cube)
https://geoscienceaustralia.github.io/digitalearthau/
31 stars 21 forks source link

Add S2 L1 & ARD products #311

Closed jeremyh closed 2 years ago

jeremyh commented 2 years ago

... used in the s2_test database

This also fixes the previous CI validation warnings, and re-enables the stricter mode of checking that was disabled in c7035cdf1f81d40a9243e16f85b4255257da2265

jeremyh commented 2 years ago

Future changes will be separate PRs. I think we're close enough to merge this now.

dunkgray commented 2 years ago

Hi Jeremy, This looks good. Could you push this up to a branch on the main repo so I can suggest some changes?

Cheers Duncan

From: Jeremy Hooke @.> Sent: Friday, 20 May 2022 12:58 PM To: GeoscienceAustralia/digitalearthau @.> Cc: Duncan Gray @.>; Review requested @.> Subject: Re: [GeoscienceAustralia/digitalearthau] Add S2 L1 & ARD products (PR #311)

@jeremyhhttps://github.com/jeremyh requested your review on: #311https://github.com/GeoscienceAustralia/digitalearthau/pull/311 Add S2 L1 & ARD products.

— Reply to this email directly, view it on GitHubhttps://github.com/GeoscienceAustralia/digitalearthau/pull/311#event-6647191872, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAIAHKJIEKFPOBBR3EKYX5TVK35T7ANCNFSM5PPXQ73Q. You are receiving this because your review was requested.Message ID: @.***>

Geoscience Australia Disclaimer: This e-mail (and files transmitted with it) is intended only for the person or entity to which it is addressed. If you are not the intended recipient, then you have received this e-mail by mistake and any use, dissemination, forwarding, printing or copying of this e-mail and its file attachments is prohibited. The security of emails transmitted cannot be guaranteed; by forwarding or replying to this email, you acknowledge and accept these risks.

jeremyh commented 2 years ago

Hi Jeremy, This looks good. Could you push this up to a branch on the main repo so I can suggest some changes? Cheers Duncan …

You should be able to add suggestions here on the PR? Or do you want to push your own commits?

dunkgray commented 2 years ago

I can't do edits to the code in the PR currently. I think I would be able to if these changes where on a branch of the main repo.

From: Jeremy Hooke @.> Sent: Friday, 20 May 2022 4:16 PM To: GeoscienceAustralia/digitalearthau @.> Cc: Duncan Gray @.>; Review requested @.> Subject: Re: [GeoscienceAustralia/digitalearthau] Add S2 L1 & ARD products (PR #311)

Hi Jeremy, This looks good. Could you push this up to a branch on the main repo so I can suggest some changes? Cheers Duncan …

You should be able to add suggestions here on the PR? Or do you want to push your own commits?

— Reply to this email directly, view it on GitHubhttps://github.com/GeoscienceAustralia/digitalearthau/pull/311#issuecomment-1132514801, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAIAHKP3G5W7IMYWKPSYBHDVK4U4FANCNFSM5PPXQ73Q. You are receiving this because your review was requested.Message ID: @.***>

Geoscience Australia Disclaimer: This e-mail (and files transmitted with it) is intended only for the person or entity to which it is addressed. If you are not the intended recipient, then you have received this e-mail by mistake and any use, dissemination, forwarding, printing or copying of this e-mail and its file attachments is prohibited. The security of emails transmitted cannot be guaranteed; by forwarding or replying to this email, you acknowledge and accept these risks.

dunkgray commented 2 years ago

Hi Jeremy, Could you push this up to a branch on the main repo?

Cheers Duncan

From: Jeremy Hooke @.> Sent: Friday, 20 May 2022 4:16 PM To: GeoscienceAustralia/digitalearthau @.> Cc: Duncan Gray @.>; Review requested @.> Subject: Re: [GeoscienceAustralia/digitalearthau] Add S2 L1 & ARD products (PR #311)

Hi Jeremy, This looks good. Could you push this up to a branch on the main repo so I can suggest some changes? Cheers Duncan …

You should be able to add suggestions here on the PR? Or do you want to push your own commits?

— Reply to this email directly, view it on GitHubhttps://github.com/GeoscienceAustralia/digitalearthau/pull/311#issuecomment-1132514801, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAIAHKP3G5W7IMYWKPSYBHDVK4U4FANCNFSM5PPXQ73Q. You are receiving this because your review was requested.Message ID: @.***>

Geoscience Australia Disclaimer: This e-mail (and files transmitted with it) is intended only for the person or entity to which it is addressed. If you are not the intended recipient, then you have received this e-mail by mistake and any use, dissemination, forwarding, printing or copying of this e-mail and its file attachments is prohibited. The security of emails transmitted cannot be guaranteed; by forwarding or replying to this email, you acknowledge and accept these risks.