search

GeoscienceAustralia / eqrm

Automatically exported from code.google.com/p/eqrm
Other
5 stars 4 forks source link

let users set length and width values for scenarios #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently weh doing a scenario the user can not set the length and width  of 
the fault.  Change things so they can.  event_set.create accepts these values 
as parameters.  Changes are needed so the values can be passed in.  Add the 
parameters to the scenario input, both defaulting to None.  Call them 
scenario_length and scenario_width.

Original issue reported on code.google.com by duncan.g...@gmail.com on 17 Feb 2012 at 4:56

GoogleCodeExporter commented 9 years ago

Original comment by duncan.g...@gmail.com on 17 Feb 2012 at 4:57

GoogleCodeExporter commented 9 years ago 
A summary of requirements as discussed with Duncan

Two new parameters to be introduced in eqrm_flags
* scenario_width
* scenario_length

These are passed through into Event_Set.create_scenario_events (note: synthetic 
events are NOT affected by these parameters - generate_synthetic_events).

create_scenario_events currently uses the eqrm_flags.max_width scalar to create 
a fault_width vector. If scenario_width and scenario_length are set, 
fault_width is to be ignored.

Original comment by b...@girorosso.com on 17 Feb 2012 at 5:19

GoogleCodeExporter commented 9 years ago 
clarifications;
Default scenario_width and scenario_length to None.

If scenario_width is set ignore max_width(->fault_width), otherwise use 
max_width, e.g. if just scenario_length is set.

Original comment by duncan.g...@gmail.com on 17 Feb 2012 at 5:28

GoogleCodeExporter commented 9 years ago 
The current way that area is generated if None.

if area is None:
    area = conversions.modified_Wells_and_Coppersmith_94_area(Mw)

For a scenario event, the area is not passed through, so the above is used.

Given that:

if length is None:
    length = area/width

This should be changed to:

1. Determine width if not set
2. Determine length if not set
3. Area = length * width

Original comment by b...@girorosso.com on 20 Feb 2012 at 12:17

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
An update on comment 4 - area is a transient value, used only to calculated 
length and width (if they're not already set). Once this work is complete, will 
work on removing it from the object altogether.

Original comment by b...@girorosso.com on 20 Feb 2012 at 2:45

GoogleCodeExporter commented 9 years ago 
Implemented in revision 947.

Included in this are updated unit tests, a new scenario test and update 
documentation.

Original comment by b...@girorosso.com on 20 Feb 2012 at 3:31