search

GeoscienceAustralia / ga_sar_workflow

InSAR processing workflow used by Geoscience Australia
Apache License 2.0
3 stars 0 forks source link

Quick fixes before end of project #371

Closed mwheeler closed 2 years ago

mwheeler commented 2 years ago

This PR just has 3 minor quick fixes:

  1. resurrects some old code that Ben accidentally removed in a cleanup, for the database ingest scripts (required for updating the geospatial DB)
  2. removes the machine-generated proxy class file from code coverage (it was previously in tests/ and excluded, now it's in insar/ it needs to be explicitly excluded (as it has wrappers for many GAMMA functions we never use, thus will never be fully covered)
  3. Fixes the dockerfile to set an env var explicitly for unit testing (which needs a mock GAMMA environment)

As there's no one left in this team, and this is my last day - this won't go through a normal review - but my justifications for allowing this are as follows:

  1. This is resurrecting code that was already approved long ago (no changes, verbatim subset of code from the last time the file existed, see: #297 (and https://github.com/GeoscienceAustralia/gamma_insar/blob/c33ef30ef0e0644ab768aec0fb7276b7bb960049/insar/scripts/grid_processing.py ) for confirmation.
  2. The other two changes are minor 1-line fixes that don't touch any of the product code at all (just a dockerfile & the py-cov config settings)