search

GeoscienceAustralia / ga_sar_workflow

InSAR processing workflow used by Geoscience Australia
Apache License 2.0
3 stars 0 forks source link

Quick fixes for ALOS1 processing #373

Closed mwheeler closed 2 years ago

mwheeler commented 2 years ago

This PR fixes a few minor issues that have impacted recent ALOS 1 processing:

  1. Fixed a long term issue where some Luigi parameters, when not provided (eg: when not providing a shapefile when doing non-S1 processing) were being given the string value "None"
  2. Fixed ALOS processing to correctly detect the "processing level" of the input data (which can either be "L1.0" (L0), or "L1.1" (L1)) to determine what workflow to pass the data through, when previously ALOS1 was assumed to be L0 and ALOS2 was L1.
  3. Fixed land center setting interpretation when no land center setting is provided (similar to the "None" string issue for shapefile).
  4. Minor install/env script fixes that were overlooked in 1.0 release.

This addresses #369 and #372

mwheeler commented 2 years ago

In this PR we also identified and fixed a bug where FBD mode acquisitions were not correctly identified for ALOS1 L1 data (this has also been resolved), which then hit another bug where Path.rename was being used to move a temp file across filesystem boundaries (we never had this issue before because no ALOS data we had was ever FBD mode) - which is now also fixed via shutil.move.