search

GeoscienceAustralia / ga_sar_workflow

InSAR processing workflow used by Geoscience Australia
Apache License 2.0
3 stars 0 forks source link

pbs_insar fails with AttributeError (when using old configs?) #379

Open daleroberts opened 1 year ago

daleroberts commented 1 year ago

pbs_insar fails with AttributeError. I suspect it happen when using an old config file and certain config parameters are no longer supported in the newer version?

TODO:

  1. Work out what the problem is...
  2. Wrap the CLI scripts with try/catch clauses to make them more user friendly.
  3. Add error messages
  4. I suspect this is a typo: https://github.com/GeoscienceAustralia/PyGamma/blob/86e4dd73b326bb16a7af0e2923f8d1c7bc9ec75c/insar/scripts/insar_pbs.py#L609
mwheeler commented 1 year ago

re: 1) without seeing a stack trace, I'd imagine you're right - https://github.com/GeoscienceAustralia/PyGamma/blob/main/insar/project.py#L139-L143 - no error checking. There's a few older .proc files out there which people still keep trying to use (despite being warned many times not to)

re: 4) no typos there (ARD = analysis ready data, SAR = Synthetic Aperture Radar, InSAR = Interferometric SAR), though the help is... poor ("Packages (In)SAR products" would be more apt)

there's a few open issues around the parameters, duplicate settings aren't picked up either (and have tripped up a few people because latest value overrides earlier ones silently), inconsistent yes/no true/false enable/disable stuff, etc. and not all parameters are even implemented (just the ones that were actively used).

The working examples are in the docs, and examples were also provided to the InSAR team on NCI - /g/data/up71/projects/InSAR-ARD/gamma_insar_examples which last I checked 'should' be up to date and working. There was a manual process in place by the ARD team (ben/myself) to keep those up to date when we did a release.

daleroberts commented 1 year ago

Thanks for the comment, I didn't realise that people were still monitoring the issues. I was just setting TODOs for this week so I didn't forget 😅