search

GeoscienceAustralia / ginan

The Australian Government, through Positioning Australia (part of Geoscience Australia), is funding the design, development and operational service of a Global Navigation Satellite System (GNSS) position correction system - the Ginan service and toolkit. The application of the Ginan correction service by a GNSS device has the potential to increase positioning accuracy from meters to centimetres across Australia. The suite of software systems in this repository (the Ginan toolkit) will be used to create the service. It is available now under an open source licence. Ginan will give individuals and organisations no-cost access to the Ginan software and service as a public good.
https://geoscienceaustralia.github.io/ginan/
Other
221 stars 107 forks source link

wrong system char code for SBAS #44

Closed thetengda closed 11 months ago

thetengda commented 1 year ago

in src/cpp/common/satSys.hpp line50 and line 64 system code for SBAS is set to lowercase 's' however, other functions (e.g. sysFromChar) use uppercase 'S' This can lead to misrecognition

Code:

define SBAS_CHAR 's'

/** Returns the character used as a prefix for this system.
*/
char sysChar()  const
{
    switch (sys)
    {
        case E_Sys::GPS:    return 'G';
        case E_Sys::GLO:    return 'R';
        case E_Sys::GAL:    return 'E';
        case E_Sys::QZS:    return 'J';
        case E_Sys::BDS:    return 'C';
        case E_Sys::LEO:    return 'L';
        case E_Sys::IRN:    return 'I';
        case E_Sys::SBS:    return SBAS_CHAR;
        default:            return '-';
    }
}
seballgeyer commented 11 months ago

Thanks for notifying us of this issue, we have fixed it in our development version. Changes will be pushed to GitHub in the coming weeks.