search

GeoscienceAustralia / ginan

The Australian Government, through Positioning Australia (part of Geoscience Australia), is funding the design, development and operational service of a Global Navigation Satellite System (GNSS) position correction system - the Ginan service and toolkit. The application of the Ginan correction service by a GNSS device has the potential to increase positioning accuracy from meters to centimetres across Australia. The suite of software systems in this repository (the Ginan toolkit) will be used to create the service. It is available now under an open source licence. Ginan will give individuals and organisations no-cost access to the Ginan software and service as a public good.
https://geoscienceaustralia.github.io/ginan/
Other
207 stars 95 forks source link

Incorrect number of seconds in a week #88

Closed Pikamander2 closed 1 month ago

Pikamander2 commented 1 month ago

Hi there, I used a code search and found an incorrect number of seconds in a week (608400 instead of 604800) listed in one of your files. I recommend fixing it to avoid incorrect timings that could potentially lead to unexpected behavior.

https://github.com/GeoscienceAustralia/ginan/blob/0f263270daa1d5234d1194d3bc314cf3dca85f38/src/cpp/common/mqtt.cpp#L36

seballgeyer commented 1 month ago

Hello,

Thank you for your attention to detail in spotting the incorrect number of seconds in a week in the mqtt.cpp file.

While this error was present, it's important to clarify that the mqtt.cpp file was part of an exploratory phase where MQTT was tested as a communication protocol. We have since decided to abandon this approach.

The code has been removed from our codebase a few weeks ago and is not present in the latest weekly snapshot on the develop-weekly branch. This ensures that the issue you've identified will not impact any future developments.

We're grateful for your contribution to improving our project's accuracy. Please feel free to verify the removal of the code in the updated branch.

If you need any further information or assistance, don't hesitate to reach out.

Best regards, Sebastien