search

GeoscienceAustralia / tcrm

A statistical-parametric model for assessing wind hazard from tropical cyclones
http://geoscienceaustralia.github.io/tcrm
Other
81 stars 52 forks source link

WindSpeed column in track being replaced with Speed in interpolate. #141

Closed davbyr closed 7 months ago

davbyr commented 1 year ago

Just a quick issue. I've been playing around with TCRM functions lately (nice package, thanks!), and was getting some concerning values in the windspeed column of tracks that were being generated by interpolateTracks.parseTracks. I'm calling this function independently to convert some existing track files (.csv) into the appropriate .nc format for Windfield and Hazard calculations. Anyway, after a little bit of digging in interpolateTracks.py I noticed this on line 184:

     _nwSpd = interp1d(timestep[validIdx],
                                      track.Speed[validIdx],
                                      kind='linear')(newtime[firsttime:lasttime])

I might have misunderstood, but I think this should use track.WindSpeed rather than track.Speed? So:

     _nwSpd = interp1d(timestep[validIdx],
                                      track.WindSpeed[validIdx],
                                      kind='linear')(newtime[firsttime:lasttime])
wcarthur commented 7 months ago

Fixed in 3.1.15 (https://github.com/GeoscienceAustralia/tcrm/releases/tag/3.1.15)