search

GeoscienceAustralia / wagl

Python library for standardising satellite imagery into an Analysis Ready Data (ARD) form
Apache License 2.0
30 stars 7 forks source link

Loading C2 metadata #346

Closed dunkgray closed 3 years ago

dunkgray commented 3 years ago

Classifying this as "Request changes" status, mostly due to unfamiliarity with the wagl project.

This PR includes multiple binary files and XML data. Is there a known reason why binaries are being added to the code repo >instead of a separate, versioned data store? Using a separate, versioned data store is an option too. The current version of wagl uses small binaries as test data. I decided to use the current structure.

There's also direct I/O in the tests: loading files for data. Is this approach a legacy from wagl's dev history? Yes, I'm testing the collection 2 data using the same way done for collection 1.

test_acquisitions.py looks ok, but I’m lacking the right background context to know if anything is wring or missing. Is there a >second reviewer around? That's ok. I'll get a second reviewer.

Thanks Ban

sixy6e commented 3 years ago

Oh and for additional context. The Travis builds are failing because the Ubuntu-GIS package that is retrieved doesn't have GDAL-3 yet. wagl requires GDAL-3, and ideally, we transition over to using GitHub Actions, but the time to do so was lacking.

dunkgray commented 3 years ago

Thanks Josh