GeospatialPython / pyshp

This library reads and writes ESRI Shapefiles in pure Python.
MIT License
1.1k stars 260 forks source link

Add context manager to Reader and other improvements #122

Closed megies closed 6 years ago

megies commented 7 years ago

Hi there, this PR proposes to add a context manager that makes sure open files are closed properly in the most Pythonic way there is (also see #107).

I've also made some other improvements (at least I think they are ;-), these can be singled out if you don't agree with all of them:

I've just started using pyshp for shapefile manipulations, thanks for the project! It's so convenient that it's noarch, pure Python and py2/3! ❤️

Eventually tests should really be implemented as unit tests, which is not a lot of work when relying on pytest, and Travis (ah Travis is set up already) and Appveyor should be set up as CI. I don't have time for this right now but might make a PR for this in the future..

Fixes #121

karimbahgat commented 6 years ago

Very useful, should make file handling more stable. Thanks 👍