search

GeospatialPython / pyshp

This library reads and writes ESRI Shapefiles in pure Python.
MIT License
1.09k stars 259 forks source link

Mark tests requiring network. #230

Closed sebastic closed 2 years ago

sebastic commented 2 years ago

The Debian package build for pyshp failed because there is no network in the build environment.

The tests that download data need to be skipped, for this the network marker was added to test_reader_url().

musicinmybrain commented 2 years ago

Thanks for this! As the maintainer of the corresponding Fedora package, it helps me out too.

(Unfortunately, I have to resort to some ugly sed hackery to accomplish the same thing in the doctests, and I’m not sure how best to do that more cleanly in a way that I offer upstream.)

sebastic commented 2 years ago

(Unfortunately, I have to resort to some ugly sed hackery to accomplish the same thing in the doctests, and I’m not sure how best to do that more cleanly in a way that I offer upstream.)

I chose to stop running those, now that a better test framework is also used. I considered adding a patch to strip out those examples, but considered it not worth the effort.