Support for getting encoding from .cpg files

GeospatialPython / pyshp

This library reads and writes ESRI Shapefiles in pure Python.

MIT License

1.09k stars 259 forks source link

Support for getting encoding from .cpg files #247

Open karimbahgat opened 2 years ago

karimbahgat commented 2 years ago

Describe the feature request

Non-standard but commonly accepted cpg file that specifies which text encoding to use. Would make for more robust handling of files and special cases. Main problem is figuring out which strings are used to represent encodings, appears to be non-standard.

May want to support both read and write support for this.

Contributions

[ ] I am interested in implementing the described feature request and submit as a PR.

JamesParrott commented 1 year ago

I'm not familiar with arc, but from googling, .cpg files do seem to be nothing more than one line text files. However their very nature does invite the following questions:

Are the .cpg files themselves encoded in utf-8, or what?
Or do all the encoding strings to be supported only use ascii characters, so it shouldn't matter if it's not utf-16?

karimbahgat commented 1 year ago

Not sure at the moment, I suspect using ascii or utf8 would be a safe assumption and work in most cases. I haven't looked very hard though. Let me know if you find out, or want to submit a PR :)