search

GeostatsGuy / GeostatsPy

GeostatsPy Python package for spatial data analytics and geostatistics. Started as a reimplementation of GSLIB, Geostatistical Library (Deutsch and Journel, 1992) from Fortran to Python, Geostatistics in a Python package. Now with many additional methods. I hope this resources is helpful, Prof. Michael Pyrcz
https://pypi.org/project/geostatspy/
MIT License
479 stars 183 forks source link

GSLIB plotting functions should allow for axis specification #29

Open jameshgrn opened 3 years ago

jameshgrn commented 3 years ago

Hi Dr. Pyrcz,

I'm currently doing your HW #2 and thought it might be useful to include axis arguments in locmap_st and hist_st so that one can supply ax1, ax2, ax3 args for further subplot customization.

I can try and create a PR sometime, but wanted to bring it up.

Jake G.

GeostatsGuy commented 3 years ago

Howdy Jake,

That is a great idea. While ‘1-liners’ are useful for convenient, concise workflow code, flexibility is also important. It is a challenge to balance this! GeostatsPy was written on the weekends, days before students needed the code in my lectures! You will see many opportunities to improve.

o. I like this idea.

Remember, any improvements implemented in GeostatsPy will result in you being added to the author list with specification of your contribution!

All the best,

Michael

MICHAEL J. PYRCZ, Ph.D., P.Eng., Associate Professor The University of Texas at Austin | Twitterhttps://twitter.com/GeostatsGuy | YouTubehttps://www.youtube.com/channel/UCLqEr-xV-ceHdXXXrTId5ig | GitHubhttps://github.com/GeostatsGuy | LinkedInhttps://www.linkedin.com/in/michael-pyrcz-61a648a1/ | Webpagehttp://www.michaelpyrcz.com/ | Bookhttps://www.amazon.com/Geostatistical-Reservoir-Modeling-Michael-Pyrcz/dp/0199731446 | GoogleScholarhttps://scholar.google.com/citations?user=QVZ20eQAAAAJ&hl=en | DiReCT Consortiumhttps://direct.pge.utexas.edu/

From: Jake Gearon notifications@github.com Sent: Tuesday, September 15, 2020 4:27 PM To: GeostatsGuy/GeostatsPy GeostatsPy@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [GeostatsGuy/GeostatsPy] GSLIB plotting functions should allow for axis specification (#29)

Hi Dr. Pyrcz,

I'm currently doing your HW #2https://github.com/GeostatsGuy/GeostatsPy/pull/2 and thought it might be useful to include axis arguments in locmap_st and hist_st so that one can supply ax1, ax2, ax3 args for further subplot customization.

I can try and create a PR sometime, but wanted to bring it up.

Jake G.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/GeostatsGuy/GeostatsPy/issues/29, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHUO3465NMESRGZA5NZY5R3SF7LZBANCNFSM4RNZTCAA.

This message is from an external sender. Learn more about why this matters.https://ut.service-now.com/sp?id=kb_article&number=KB0011401

jameshgrn commented 3 years ago

Pyrcz,

Sounds good, I just try my best to flag things as I use open source packages (and hopefully PR them as a follow-up when possible). I'll do the PR this weekend. See you tomorrow!

Jake

jameshgrn commented 3 years ago

keeping it open until I do it. Cheers