search

Geosyntec / StormPiper

Mozilla Public License 2.0
0 stars 1 forks source link

Fix scenario and bmp inventory form behavior #302

Closed acang-gs closed 10 months ago

acang-gs commented 10 months ago

This fixes issues where toggling between simple/non-simple in the bmp inventory form would reset the facility type to the previously saved value, and where scenario facility updates were not getting submitted properly.

@austinorr please feel free to pull this down and test

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1cea452) 97.02% compared to head (616782a) 97.02%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #302 +/- ## ======================================= Coverage 97.02% 97.02% ======================================= Files 127 127 Lines 3927 3927 Branches 569 569 ======================================= Hits 3810 3810 Misses 80 80 Partials 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

acang-gs commented 10 months ago

doesn't work fully. If i change to detailed and save. my changes work. if i then change back an submit, the BMP type still doesn't update. screenshot of what should be a "_simple" bmp being patched to the backend, but instead it's a detailed one.

image

Hm, I'm actually unable to reproduce this. Working with the 'tmnt_scenario', I'm able to edit the facility to be both a simple and non-simple, and it is represented in the patch blob correctly. This occurs both when I perform these actions in the same session (i.e. click edit, toggle simple, save, click edit, toggle non-simple, save), and across sessions (i.e. click edit, toggle simple, save, refresh, click edit toggle non-simple, save). So it seems like this is slightly more complicated than I thought.

austinorr commented 10 months ago

I think you're right, that this was a me-thing some how. today after pulling and re-building this branch i can't reprod the image i captured last night either.

Apologies for the additional time it took you to check on that again, i appreciate you looking into it.

From what I can tell, this issue is fully closed. Nice work, thanks for rushing it in before the holidays. Much appreciated!