GeotrekCE / Geotrek-admin

Paths management for National Parks and Tourism organizations
https://geotrek.fr
BSD 2-Clause "Simplified" License
136 stars 76 forks source link

Inconsistency on python 3.6 versions in CI environments #3206

Closed marcantoinedupre closed 1 year ago

marcantoinedupre commented 2 years ago

I have 2 failed tests when testing locally on python 3.6.9 which do not happen on the CI.

Both failed on error: ValueError: unsupported pickle protocol: 5

To reproduce run the test suite inside a docker container based on makinacorpus/geodjango:bionic-3.8.

I noticed that the CI on Github Actions uses an environment Ubuntu-18.04 + python3.6 to run the test suites. This leads to python 3.6.15 being used. But the latest version of python-3.6 on Ubuntu-18.04 is 3.6.9. Maybe that is the cause.

So maybe we should we pin the PATCH version for python-3.6 on the CI:

strategy:
      matrix:
        os: [ubuntu-18.04, ubuntu-20.04]
        tests-env: ['tests', 'tests_nds']
        include:
          - os: ubuntu-18.04
            python-version: 3.6.9  # default python version in 18.04
          - os: ubuntu-20.04
            python-version: 3.8  # default python version in 20.04
submarcos commented 1 year ago

py 3.6 not maintained anymore