search

GeotrekCE / Geotrek-rando

Geotrek public trekking website
http://geotrek.fr
31 stars 18 forks source link

made FILTERS_DEFAULT_OPEN explanation more clear #775

Closed pierreloicq closed 3 years ago

pierreloicq commented 4 years ago

Wouln't be nice to put "FILTERS_DEFAULT_OPEN : true" by default ?

camillemonchicourt commented 4 years ago

Thanks. Yes Default True sounds good to me.

gutard commented 4 years ago

Thanks for this PR. However, it refers to sliders whereas filters can be checkboxes too. Moreover, the fact that sliders are not correctly initialized when FILTERS_DEFAULT_OPEN is not set is a bug and should not be documented.

Changing defaults along the way is not a good idea. The behaviour of existing installations will change unexpectedly on upgrade.

camillemonchicourt commented 3 years ago

The suggestion is good as the actual option details are not clear but just need to be changed for something like "If true, the filters values will be expanded by default"