search

Geovation / labelgun

🏷️ reducing label clutter across mapping libraries
https://geovation.github.io/labelgun/
113 stars 10 forks source link

Add GH pages so examples work online #13

Closed tomchadwin closed 7 years ago

JamesLMilner commented 7 years ago

Working on this! Might mean you have to change your PR to go back to the CDN though rather than relative files

tomchadwin commented 7 years ago

Wouldn't be a problem, though I don't quite see why it would be necessary.

JamesLMilner commented 7 years ago

The way we publish gh-pages is using subtrees which mean you can't access parent level folders. The benefit is that it makes deploying changes to examples to gh-pages much easier.

The GH Page is now live by the way: https://geovation.github.io/labelgun/

tomchadwin commented 7 years ago

But it does work:

https://geovation.github.io/labelgun/leaflet/index.html

Or do you mean you've not implemented subtrees yet?

tomchadwin commented 7 years ago

Closing for now - will revert examples to CDN if they fail in the future.

JamesLMilner commented 7 years ago

Yes it works currently because they're using the CDN currently. If you use the local library they will fail because it can't access code outside the subtree.

tomchadwin commented 7 years ago

OK. I was out of sync. Think my PR is good to go now.