search

Geovation / labelgun

🏷️ reducing label clutter across mapping libraries
https://geovation.github.io/labelgun/
113 stars 10 forks source link

Labelgun fails with none debug version of OpenLayers for SVG layer example #18

Open JamesLMilner opened 7 years ago

JamesLMilner commented 7 years ago

Haven't quite got to the bottom of it, but something to do with the fact that OL is minifed by closure compiler, the objects have mangled property names. Hard to debug as no actual error is thrown however. Will try to dig in when I have a moment or someone needs it desperately!

tomchadwin commented 7 years ago

Confirmed - never seen any difference in behaviour between debug and minified versions before. Really odd.

tomchadwin commented 7 years ago

Are you calling a private method or some such, rather than the published API?

JamesLMilner commented 7 years ago

@tomchadwin possibly, I need to take a look at all the methods I use and figure out which one was problematic.

JamesLMilner commented 6 years ago

Change this to:

<script src="https://cdnjs.cloudflare.com/ajax/libs/openlayers/4.3.3/ol-debug.js"></script>

to:

<script src="https://cdnjs.cloudflare.com/ajax/libs/openlayers/4.3.3/ol.js"></script>

to reproduce.