Gepetto / example-robot-data

Set of robot URDFs for benchmarking and developed examples.

BSD 3-Clause "New" or "Revised" License

143 stars 51 forks source link

Synchronizing simple_humanoid in pinocchio/models and example_robot_data #112

Closed proyan closed 2 years ago

proyan commented 2 years ago

I suggest that we move pinocchio's simple_humanoid from pinocchio/models to example_robot_data. It would make the sample humanoid available for other packages as well. Any views?

jcarpent commented 2 years ago

Totally fine on my side.

proyan commented 2 years ago

Ah my bad! It looks like it is already there, but is duplicated in pinocchio! This issue is ill-placed, I'll close it.

proyan commented 2 years ago

I'll create a PR synchronizing the models from pinocchio and here, let's change the direction of this issue :)

cmastalli commented 2 years ago

It sounds good for me as well. Thanks @proyan for taking care of it :)

cmastalli commented 2 years ago

Is this issue sorted out?

nim65s commented 2 years ago

Actually, I added this robot in #69, 8 months before this PR, so I'm not sure what this PR is about.

proyan commented 2 years ago

120 handles the changes I was proposing