search

Gepetto / example-robot-data

Set of robot URDFs for benchmarking and developed examples.
BSD 3-Clause "New" or "Revised" License
143 stars 51 forks source link

added Articulated soft robot loader and description #115

Closed spykspeigel closed 2 years ago

spykspeigel commented 2 years ago

I have added a 2DOF articulated soft robot with its description and loader.

cmastalli commented 2 years ago

Thanks @spykspeigel for sharing this model. Before merging this PR, it is important for us to understand:

  • where does this model come from? Can it be provided by anybody?
  • does this model will be useful to the whole community of Pinocchio, Crocoddyl and other software users?

By the way, you should only provide the minimal set of files to make things loadable by the parsers. At the time being, there are a lot of files that are not required (CMake files for instance).

@spykspeigel is working with me. This robot will eventually be useful for Crocoddyl, when we finished our ongoing work.

The robot is originally designed by Pisa. I guess we are authorized to publish this data, right @spykspeigel ?

Furthermore, as pointed out by @jcarpent, we really need the smallest set of files, which are the urdf and dae files.

You need to remove the xacro, launch, STL files.

spykspeigel commented 2 years ago

Dear All, Thanks for the comments. I have made the suggested changes i.e. removed the unnecessary files, added readme and license files. Kindly let me know if it needs any further changes.

spykspeigel commented 2 years ago

@nim65s the urdf file in two_dof_description depends on the dae files from simplecube_description. So I have moved the corresponding files in folder qb_meshes to the two_dof_description and removed simplecube_description .