search

Gepetto / example-robot-data

Set of robot URDFs for benchmarking and developed examples.
BSD 3-Clause "New" or "Revised" License
150 stars 54 forks source link

Add simplified double pendulum #118

Closed justinberi closed 2 years ago

justinberi commented 2 years ago

Adds a standalone double pendulum urdf . https://github.com/loco-3d/crocoddyl/pull/1058

hrp2-14 commented 2 years ago

Hi ! This project doesn't usually accept pull requests on master. If this wasn't intentionnal, you can change the base branch of this pull request to devel (No need to close it for that). Best, a bot.

nim65s commented 2 years ago

Thanks for this simple model.

Just to be explicit, about this, is this file an original work from you ? And if this the case, is BSD-2-Clause license OK for you ?

Otherwise, where does this come from and what is its original license ?

Also, it would be nice to add a loader after this one: https://github.com/Gepetto/example-robot-data/blob/2b998b16a2544cd2392ee6f9cc075362e6259974/python/example_robot_data/robots_loader.py#L494, add this loader to the ROBOTS dict, and add a unit test after this one: https://github.com/Gepetto/example-robot-data/blob/2b998b16a2544cd2392ee6f9cc075362e6259974/unittest/test_load.py#L57

Can you do this, or would you prefer me to handle that ?

justinberi commented 2 years ago

No problems. Happy to contribute!

Just to be explicit, about this, is this file an original work from you ? And if this the case, is BSD-2-Clause license OK for you ?

It is modified from double_pendulum.urdf. To remove the meshes (and also added a frame for the endeffector). Yes happy with BSD-2-Clase license. I am happy to inherit the license.

Because it is so heavily modified, would you like it in a different directory?

Added loader and unittests.

nim65s commented 2 years ago

Thanks a lot !

cmastalli commented 2 years ago

@nim65s -- would be possible to release a new version soon? (perhaps after merging Laikago PR)

I would like to proceed with the other PR created in Crocoddyl.

Thx