search

Gepetto / example-robot-data

Set of robot URDFs for benchmarking and developed examples.
BSD 3-Clause "New" or "Revised" License
150 stars 54 forks source link

Enable jrl-cmakemodules workspace compatiblity #225

Closed jorisv closed 1 month ago

jorisv commented 3 months ago

@cmastalli Did the modifications are fine to you ?

cmastalli commented 3 months ago

@cmastalli Did the modifications are fine to you ?

I think we should not remove the in https://github.com/Gepetto/example-robot-data/pull/225#discussion_r1679691018. However, I would like to hear from @nim65s on this topic.

jorisv commented 3 months ago

@cmastalli I revert the change about add_project_dependency({eigenpy,pinocchio}).

If it's fine to you, you can merge.

jcarpent commented 2 months ago

@cmastalli ping to merge this PR if you are fine.

cmastalli commented 2 months ago

@cmastalli ping to merge this PR if you are fine.

Hi @jcarpent -- We're just missing to address this comment: https://github.com/Gepetto/example-robot-data/pull/225#discussion_r1692859261.

This should take no time to do it.