search

Gepetto / example-robot-data

Set of robot URDFs for benchmarking and developed examples.
BSD 3-Clause "New" or "Revised" License
143 stars 51 forks source link

Add finger_edu robot #91

Closed jviereck closed 3 years ago

jviereck commented 3 years ago

Adding the finger robot as discussed in #90 .

I've added unit tests. However, it is not clear to me how to run them. Can someone tell me what I need to do for this?

hrp2-14 commented 3 years ago

Hi ! This project doesn't usually accept pull requests on master. If this wasn't intentionnal, you can change the base branch of this pull request to devel (No need to close it for that). Best, a bot.

jviereck commented 3 years ago

For that, run yapf -ri . in the root of this project.

If I do this it change the content of a lot of the files in the repo (also ones I didn't work on). Is this intended? Should these changes be included in this PR?

jcarpent commented 3 years ago

Just take into account the change related to your current PR.

jviereck commented 3 years ago

Okay, I was missing a single newline in terms of formatting. Pushed the change only to that code section of the file as a new commit.

jviereck commented 3 years ago

Thanks everyone for the review. Is there something else missing to merge this? I don't have a green merge button so I guess some maintainer of this package has to do the merge?