search

Gepetto / gepetto-viewer

Graphical Interface for Pinocchio and HPP.
BSD 2-Clause "Simplified" License
41 stars 30 forks source link

Improve UI experience. #130

Closed jmirabel closed 4 years ago

nim65s commented 4 years ago

Hi,

It looks like this broke the  CI (it was OK for the PR before): https://gepgitlab.laas.fr/gepetto/gepetto-viewer/-/jobs/68044:

…/src/node-property.cpp:513:9: error: 'class QComboBox' has no member named 'setCurrentText'; did you mean 'setCurrentIndex'?
cb->setCurrentText(QString::fromStdString(value));

It looks like an issue between QComboBox Qt4 / Qt5.

jmirabel commented 4 years ago

You are right. setCurrentText is not available in Qt4.

florent-lamiraux commented 4 years ago

Compiling with QT4, I get this error message: /home/florent/devel/pyrene/src/gepetto-viewer/src/node-property.cpp:340:11: error: ‘QOverload’ was not declared in this scope

jmirabel commented 4 years ago

Compiling with QT4, I get this error message: /home/florent/devel/pyrene/src/gepetto-viewer/src/node-property.cpp:340:11: error: ‘QOverload’ was not declared in this scope

Right. introduced in Qt 5.7.

florent-lamiraux commented 4 years ago

Now, I have the same error message as @nim65s : .../src/node-property.cpp:513:9: error: ‘class QComboBox’ has no member named ‘setCurrentText’; did you mean ‘setCurrentIndex’?

florent-lamiraux commented 4 years ago

Now it is qInfo that is not defined: src/gepetto-viewer/src/gui/mainwindow.cc:570:11: error: ‘qInfo’ was not declared in this scope

florent-lamiraux commented 4 years ago

After adding #include <gepetto/viewer/config-osg.h> in include/gepetto/gui/pick-handler.hh, I get the following error: /src/gepetto-viewer/tests/properties.cpp:29:10: fatal error: QtConcurrent: No such file or directory This is the last test, so we are almost there.

jmirabel commented 4 years ago

Thanks for the feedback @florent-lamiraux I now use my gepgitlab fork to check that everything works fine. I will push here when everything is ready.

jmirabel commented 4 years ago

Everything should be ok now.

florent-lamiraux commented 4 years ago

I pushed some correction to git@github.com:florent-lamiraux/gepetto-viewer.git. It now compiles, but the tests do not pass.

florent-lamiraux commented 4 years ago

The following line fails https://github.com/Gepetto/gepetto-viewer/blob/ebd9d4f8141641031b78ed2483bcffb4f73f3988/tests/nodes.cpp#L81 but method applyConfiguration does not seem to set dirty_ to false anymore.

florent-lamiraux commented 4 years ago

Forget my previous comment. I did not get your latest version.