search

GepocUS / Spcies

Suite of Predictive Controllers for Industrial Embedded Systems. A Matlab toolbox for automatic code generation of solvers for MPC controllers.
Apache License 2.0
14 stars 2 forks source link

in_engineering option should be provided in `options`, and not `solver_options` #33

Closed pablokrupa closed 6 months ago

pablokrupa commented 1 year ago

Similar to #25, but for the in_engineering options. Currently, to set the in_engineering option to true the solver_options structure must contain a field .in_engineering = true. It would be more logical for this field to be included in the options structure instead.

pablokrupa commented 11 months ago

Another alternative here would be to simplify the two options structures into a single structure. Particularly because evidently it is not clear where some options should go (see Issue #25, for example).

That is, instead of having a solver_options and a options, we could merge then into a unique opt. Each solver and MPC formulation could modify the given opt to add the missing fields (with their optional values). That way the problem of where a specific option should go disappears (see Issue #25).

pablokrupa commented 6 months ago

This issue has been fixed as of release 'v0.3.10' (bb8406630ea952b0b5ba63e180d0030f91e8390c), since options are now handled by the Spcies_options class.