search

GeppettoJS / backbone.geppetto

Bring your Backbone applications to life with an event-driven Command framework.
http://geppettojs.github.com/backbone.geppetto/
MIT License
203 stars 28 forks source link

Improve examples part #41

Closed mulderp closed 10 years ago

mulderp commented 10 years ago

Hi,

in order to add more examples, I moved the widgets example to a subdirectory. I also edited the Readme slightly, adding a reference to the demo provided by @niki4810.

Well, I am just playing around with the new features of Backbone.Geppetto, and plan to add the insights to the movies example in the /examples directory.

Let me know what you think!

Patrick

geekdave commented 10 years ago

Thanks @mulderp !

@niki4810 : It would be great if you could move the movies example source code to be part of the Geppetto repo, so it's easier for others to hack on it.

niki4810 commented 10 years ago

@geekdave , I will do that.

mulderp commented 10 years ago

@niki4810 I can do a PR for the movies examples too? But maybe you want to do some tunings/stylings, so, I wait for your ping if you need help. Great to hear it's merged too.

niki4810 commented 10 years ago

@mulderp you can go ahead with the pull request if you have the code ready. For styling I just used bootstrap. If not I am planning on submitting a PR this weekend.

mulderp commented 10 years ago

The PR for the movies example is this: https://github.com/ModelN/backbone.geppetto/pull/42

But maybe I should squash the commits even more. Also, the demo may be extended to use the new DI features of Geppetto. Another cool thing would be to decrease the actual counters depending on which filters are active/to allow for multiple filters.

On Fri, Jan 17, 2014 at 7:28 PM, Nikhilesh Katakam <notifications@github.com

wrote:

@mulderp https://github.com/mulderp you can go ahead with the pull request if you have the code ready. For styling I just used bootstrap. If not I am planning on submitting a PR this weekend.

— Reply to this email directly or view it on GitHubhttps://github.com/ModelN/backbone.geppetto/pull/41#issuecomment-32631719 .