search

GeppettoJS / backbone.geppetto

Bring your Backbone applications to life with an event-driven Command framework.
http://geppettojs.github.com/backbone.geppetto/
MIT License
203 stars 28 forks source link

Updates #67

Closed creynders closed 10 years ago

creynders commented 10 years ago

Hi @geekdave a number of fixes, and improvements:

  1. I fixed the double line as mentioned by @mmikeyy
  2. Optimized the applyToConstructor function
  3. Added a factory/constructor method for views as proposed in #50 which means you can use injected views either as a factory function or as a constructor function
  4. Fully refactored Geppetto. This simply means I merged the Resolver object into the Context. The separation made sense when we started out with the DI, but it had become a weird mess with some wire* methods hanging directly on the context others in resolver etc. In fact, two classes weren't necessary since they were tightly coupled anyway.

If you don't like any of this either cherry-pick the ones you do or let me know and I'll do it for you.

creynders commented 10 years ago

Ah, I didn't have the courage to merge the spec files. Which would be a bad idea anyway, since they're becoming huge. I think it would be best to fully refactor the tests as well and split them up into (a) pure unit test(s) of the API and some functionality tests.

creynders commented 10 years ago

@geekdave So what do you think? Could you Shall I :grin: cut a patch release? Everything's backwards compatible, but maybe the added API methods warrant a minor release?

I didn't bother with adding the view factories to the readme yet, since a full rewrite of the docs is one of the first things that needs to happen now IMO.

geekdave commented 10 years ago

@creynders Looks great - I think it's patch release time. Please feel free to do the honors!

creynders commented 10 years ago

@geekdave 0.7.1 is fully prepared and tagged. But. I don't have permissions to publish it on npm. Could you add me with 

npm owner add creynders backbone.geppetto

?

geekdave commented 10 years ago

@creynders : I just published 0.7.1 to npm, and also added you to the maintainers.

creynders commented 10 years ago

@geekdave thanks! :beers: