search

GeppettoJS / backbone.geppetto

Bring your Backbone applications to life with an event-driven Command framework.
http://geppettojs.github.com/backbone.geppetto/
MIT License
203 stars 28 forks source link

allow the wiring of falsy values (+ test) #81

Open mmikeyy opened 9 years ago

mmikeyy commented 9 years ago

allow the wiring of falsy values (+ test)

mmikeyy commented 9 years ago

Hi @creynders Finally found some time to do this.

This process is amazingly cumbersome btw. I don't know why the tests just won't run on my local machine. They keep stumbling on missing dependencies and what not. I had to go by trial and error on the remote travis ci.

All that time for this minute patch.

Anyway. It's done. I hope it's ok.

hmm... I'll do one more iteration just to be sure. I'll leave the test but remove the patch to make sure the test fails without the patch. I'll put the patch back after.

mmikeyy commented 9 years ago

Hey @creynders ...

I changed my tests because I noticed that tests pertaining to the wiring of values were present in the resolver-specs.js batch.

I took the liberty to change one of the existing tests. See comments in the code.

The tests I added are supposed to fail. That's the intended result. I'll patch the code when the tests fail, and I can observe that they stop failing with the patch added.

But alll of a sudden, it's Travis that is acting up. Getting the same error I get at home:

Warning: PhantomJS timed out, possibly due to a missing Mocha run() call. Use --force to continue.

It's strange to be getting this error after only minor changes to tests that were not causing any problems shortly before...

In any event, could you have a look at these tests and let me know if you have any idea what's going on??

*** update:

ok I figured out everything. I do these things so rarely that it seems that I have to relearn everything each time. Had to uninstall NPM and reinstall. Then Grunt was able to install. etc etc. And now everything works even in Jetbrains...