Closed evgeni closed 5 years ago
They're not all in the tmp2
folder. It also contains a .git
file which it should not.
$ cat node_modules/jison-gho/.git
gitdir: ../../../.git/modules/lib/modules/tooling/jison
For the benefit of anyone googling this, if you are building a node application via Jenkins that includes jison-go as a dependency, the build will fail with the error
hudson.plugins.git.GitException: Command "git clean -fdx" returned status code 128:
stdout:
stderr: fatal: Not a git repository: node_modules/jison-gho/../../../.git/modules/lib/modules/tooling/jison
Not sure if this is related but our CI process ran into this due to a dependency of this package.
+ git clean -fdx
fatal: Not a git repository: node_modules/@gerhobbelt/recast/../../../.git/modules/lib/modules/js/recast
Seems the version of recast this package uses has a dependency with a .git file in it. Confirmed that later versions don't have this issue.
Same problem here, CI is failing trying to build an RPM (rpmbuild) and it fails on this dependency. Came in as a sub-dependency of stylelint
https://github.com/stylelint/stylelint/blob/9.10.0/package.json#L57
Looks like it was removed as a dependency in the latest stylelint release: https://github.com/stylelint/stylelint/pull/3915
Recommend upgrading stylelint to 9.10.1 if that's how it came into y'alls projects.
A new jison-gho
package version has been published on npm
today to fix this issue. It's regrettable y'all had to wait so long for this. 😢
(Note: jison -v
still reports itself as 0.6.1-215 instead of 0.6.1-216 as this is a patched release purely for this issue. Only package.json has been updated to the new build number.)
For those interested in some odd background about this: jison-gho
is developed on a Windows dev machine with msys, etc. and I finally found what's going wrong with the .gitignore and .npmignore files there. It's odd, but here's an extract of the new .npmignore file:
## WARNING ## WARNING ## WARNING ## WARNING ## WARNING
##
## Looks like npm (and git?) has a bug on Windows where the fnmatch pattern with
## trailing slash, e.g. `output/`, doesn't work for subdirectories, while the same pattern
## *without* the trailing slash *does* work for filtering directories (behaviour like
## `**/tmp/` but git and npm supports a different set of glob patterns)
##
## Commandline to observe this behaviour (on Windows dev box):
##
## npm pack && tar ftv *.tgz | grep tests
##
## Edit the ignore file to edit the `tests` line further below with or without trailing `/` to
## observe the buggy behaviour.
##
## WARNING ## WARNING ## WARNING ## WARNING ## WARNING
...
# scratch space
#tmp/
#---^ see WARNING at the top of this file!
tmp
# additional crap thast shouldn't land in git repo or npm:
#tmp*/
#---^ see WARNING at the top of this file!
tmp*
Closing this as solved due to https://github.com/GerHobbelt/jison/issues/43#issuecomment-483011578
Ohai,
jison-gho
(0.6.1-215) on NPM contains (IMHO) unrelated files, that account for about of 21MB of data. They are all in thetmp2
folder:I think all these don't belong into the distributed package and should be removed.
FWIW, the sha256 of the package I got is: